Merged
Conversation
63 tasks
Contributor
Author
|
@slnode test please |
| loopback-sdk-angular-*.tgz | ||
| !intl/ | ||
| intl/* | ||
| !intl/en/ |
Member
There was a problem hiding this comment.
- Add an empty line at the end of file;
- I think you don't need
!intl/, do you?
Contributor
Author
There was a problem hiding this comment.
there is an empty line EOF, or else github gives you an icon
Contributor
|
LGTM. Please squash commits and merge. |
Contributor
Author
|
@slnode test please |
|
|
||
| /* eslint quotes: ["error", "single"] */ | ||
| var fs = require('fs'); | ||
| var g = require('strong-globalize')(); |
Member
There was a problem hiding this comment.
This should be inside the try/catch below where require('loopback') is done. This is what allows apidocs.strongloop.com to work without installing any dependencies.
This line is the root cause of strongloop-internal/apidocs.strongloop.com#56 :-(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to strongloop/loopback#2422