Merged
Conversation
63 tasks
Contributor
|
There is a linting error: 146:1 error Line 146 exceeds the maximum line length of 90 max-len
��� 1 problem (1 error, 0 warnings)``` |
richardpringle
force-pushed
the
globalization
branch
from
c591957 to
2d60941
Compare
Contributor
Author
|
@0candy did you get a chance to review the rest? I fixed the linting error. |
Contributor
|
@richardpringle The changes LGTM. |
Contributor
Author
|
@davidcheung nice catch |
Contributor
Author
|
@slnode test please |
richardpringle
force-pushed
the
globalization
branch
from
4974217 to
7a88e5f
Compare
davidcheung
force-pushed
the
globalization
branch
from
7a88e5f to
85ba504
Compare
richardpringle
force-pushed
the
globalization
branch
from
85ba504 to
7a88e5f
Compare
| "debug": "^2.2.0", | ||
| "ejs": "^1.0.0", | ||
| "lodash": "^3.10.1", | ||
| "strong-globalize": "^2.6.0", |
Contributor
There was a problem hiding this comment.
It's now ^2.6.6, but a nit since ^ picks it up anyways during install.
Contributor
|
One minor comment that is just a nit, otherwise LGTM. |
Contributor
Author
Contributor
|
@richardpringle You can merge this PR as all the test are green, only the dependents are failing. I am working on the timeout issue on workspace. Thanks! |
Contributor
|
@richardpringle I fixed some in loopback, but not in workspace. Miroslav mentioned he will take a look why test run so slowly recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect to strongloop/loopback/issues/2422
@0candy, please review.