template/api-server: introduce middleware.json#169
Merged
Conversation
bajtos
force-pushed
the
feature/middleware-json
branch
from
November 27, 2014 19:26
b177166 to
241da9c
Compare
6 tasks
Member
|
LGTM |
Rework the scaffolded server app to register middleware via the new `middleware.json` file. Note: `serve-static` is kept inside `server/server.js` for now, as there isn't any mechanism for resolving paths in middleware config specified in `middleware.json`.
bajtos
force-pushed
the
feature/middleware-json
branch
from
December 1, 2014 18:27
241da9c to
3071a26
Compare
Member
|
👍 |
bajtos
added a commit
that referenced
this pull request
Dec 1, 2014
template/api-server: introduce middleware.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the scaffolded server app to register middleware via
the new
middleware.jsonfile.Note:
serve-staticis kept insideserver/server.jsfor now,as there isn't any mechanism for resolving paths in middleware config
specified in
middleware.json. I will fix this later./to @ritch @raymondfeng please review
A part of #167