Skip to content

add strong-error-handler template #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loay wants to merge 5 commits into from
Closed

add strong-error-handler template #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd83328
add strong-error-handler template
Apr 18, 2016
fa6d0bc
edit project templates
Apr 19, 2016
7a21370
update strongErrorHandler Templates
Apr 26, 2016
75cecda
update data file
Apr 26, 2016
8e366f0
revert changes outside template
May 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"async": "^0.9.0",
"cookie-parser": "^1.3.2",
"debug": "~1.0.1",
"errorhandler": "^1.1.1",
"strong-error-handler": "^1.0.0",
"fs-extra": "~0.22.1",
"glob": "~4.0.2",
"lodash": "^3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions server/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"limit": "100kb"
},
"cors": false,
"errorHandler": {
"disableStackTrace": false
"strongErrorHandler": {
"debug": false
}
},
"legacyExplorer": false
Expand Down
2 changes: 1 addition & 1 deletion server/middleware.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"loopback#urlNotFound": {}
},
"final:after": {
"errorhandler": {}
"strong-error-handler": {}
}
}
4 changes: 2 additions & 2 deletions templates/projects/empty-server/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ template.server = {
limit: '100kb'
},
cors: false,
errorHandler: {
disableStackTrace: false
strongErrorHandler: {

@bajtos bajtos Apr 28, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it difficult to review changes in templates without seeing the corresponding changes in runtime (strong-remoting and/or loopback). Could you please point me to a pull request adding strongErrorHandler config option to strong-remoting?

debug: false
}
}},
{ name: 'legacyExplorer', value: false }
Expand Down
9 changes: 9 additions & 0 deletions templates/projects/empty-server/files/server/middleware.development.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"final:after": {
"strongErrorHandler": {
"params": {
"debug": true
}
}
}
}
4 changes: 2 additions & 2 deletions templates/projects/empty-server/files/server/middleware.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"helmet#xssFilter": {},
"helmet#frameguard": {
"params": [
"params": [
"deny"
]
},
Expand All @@ -26,7 +26,7 @@
"helmet#hidePoweredBy": {},
"helmet#ieNoOpen": {},
"helmet#noSniff": {},
"helmet#noCache": {
"helmet#noCache": {
"enabled": false
}
},
Expand Down
9 changes: 0 additions & 9 deletions templates/projects/empty-server/files/server/middleware.production.json
View file
Open in desktop

This file was deleted.