Loopback expects loopback-datasource-juggler, but no longer requires it#28
Conversation
|
Test FAILed. To trigger a build add comment - ".test\W+please" |
|
Considering what the Workspace does now, this Looks Good to Me. |
|
hang on. |
|
loopback-datasource-juggler is a peerDependency of loopback, which is already defined as a dependency of loopback-workspace in it's package.json. When you run Seems there might be a bug in our CI tool? |
|
If we don't want/cannot fix the CI tool now, then a better fix may be to require the loobpack-datasource-juggler as devDependency instead of a regular dependency? |
|
Ah, I think I see the problem now. Because loopback is "installed" from Artifactory using strong-install instead of npm, it doesn't take loopback's peerDependencies into account when generating loopback-workspace's dependencies. That said, from my understanding of peerDependencies, it is meant to control versions of peer dependencies more than control that they are actually installed. This dependency chain and use of peerDependencies in loopback seems wrong to me some how... |
|
Test FAILed. To trigger a build add comment - ".test\W+please" |
Hmm, maybe you are right. Let's discuss that in strongloop/loopback#85. In the meantime, pick whatever solution works best for you. |
Because loopback lists loopback-datasource-juggler as a peerDependency but still require()s it directly, it must be present for tests to run. Under normal usage, the loopback dependency would pull in loopback-datasource-juggler. This is mainly for dev/CI.
|
Test FAILed. To trigger a build add comment - ".test\W+please" |
|
Per the discussion in strongloop/loopback#85, @bajtos @raymondfeng and/or @Schoonology confirm good to merge now? |
Loopback expects loopback-datasource-juggler, but no longer requires it
5 participants
Not sure if this change should be in loopback-workspace or in loopback.
Notice that CI is still failing, but now it is due to a failing test, not a test crashing because a
require()failed./to @Schoonology @ritch @raymondfeng @bajtos