-
Notifications
You must be signed in to change notification settings - Fork 33
Fixes for yeoman generator #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e3c037e
package: add mocha as dev-dep and test script
8028ec7
ModelDefinition: include `name` in the json file
886d114
Workspace: implement `listAvailableConnectors`
bcad05b
ModelProperty: implement `availableTypes`
dcd88eb
ModelAccessControl: improve metadata providers
f27075c
Fix serialization of Model ACLs.
30a29a9
connector: fix race condition in loadFromFile
99b28f5
ModelAccessControl: rename 'method' to 'property'
b9eb40e
Fix deserialization of embedded key-value maps
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| [ | ||
| { | ||
| "name": "memory", | ||
| "description": "In-memory db", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "mysql", | ||
| "description": "MySQL", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "postgresql", | ||
| "description": "PostgreSQL", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "oracle", | ||
| "description": "Oracle", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "mssql", | ||
| "description": "Microsoft SQL", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "mongodb", | ||
| "description": "MongoDB", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "soap", | ||
| "description": "SOAP webservices", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
| { | ||
| "name": "rest", | ||
| "description": "REST services", | ||
| "supportedByStrongLoop": true | ||
| }, | ||
|
|
||
| { | ||
| "name": "neo4j", | ||
| "description": "Neo4j", | ||
| "supportedByStrongLoop": false | ||
| }, | ||
| { | ||
| "name": "kafka", | ||
| "description": "Kafka", | ||
| "supportedByStrongLoop": false | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to change this in 2.0. "Access Control Lists" is misleading / incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like
permissions, it was used by 2.0 workspace API.Unless you have time to implement that change today, I am proposing to merge this PR and make the change later.
BTW to make the migration easy, LB 2.0 should support both old (
acls) and the new property when reading config files. workspace should probably support the old name too at read-time