Fix copying of static files - #61
Merged
Merged
Conversation
Member
|
I am confused, the patch seems to contain two changes:
What do you intend to use |
Member
There was a problem hiding this comment.
Seems the exec function is not that useful at the end. What modules are missing? Perhaps they can be added to workspace dev-dependencies?
Member
|
I am proposing the following steps:
That should catch most of the problems in templates. I have already fixed few of them in #63. |
Member
Author
Done. Can we merge this now? |
Member
There was a problem hiding this comment.
This test does not assert anything, it should be removed IMO.
Member
|
I have merged this pull request as it was blocking my progress. The comment above can be addressed in a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/to @bajtos
This patch fixes file copying for
addComponent().