"loaded" opertation observer -- either docs are incorrect or implementation is buggy

[dregre]

The docs say, in relation to the loaded operation hook:

LoopBack invokes this hook after the connector fetches data, but before creating a model instance from that data. This enables hooks to decrypt data (for example). NOTE: This hook is called with the raw database data, not a full model instance. (My emphasis)

However, after attaching a debugger and inspecting the ctx returned to my loaded callback, I've noticed that:

1. The ctx object has no data property at all;
2. Contrary to what the description says, it does contain a model instance.

E.g.:

MyModel.observe('loaded', function(ctx, next){
    console.log(ctx); // Added a breakpoint here.  Inspected `ctx`.
                      // Does contain `instance`.  Doesn't contain `data`.
    next();
});

I'm not sure whether the documentation is incorrect or the implementation is buggy?

[dregre]

I think this might be a bug. I've noticed varying behavior:

1. When my loaded hook is called incident to one of my auto migrations (app.dataSources.db.automigrate), whose callback calls create on the model, then ctx has data but no instance.
2. When my loaded hook is called afterwards, e.g., when I find a record, the ctx has an instance but no data.

Could this varying behavior be due to the fact that the first one is called on create and the second one is called on find? Is this intentional?

[richardpringle]

hmm.. @dregre, do you have a sample repo that I can clone and see what's going on? See the wiki for details on how to do this.

To me, it looks like you've found a bug but I would like to confirm.

[bajtos]

Yep, this looks like a bug in the implementation of find to me, see the source code and the original pull request which introduced this hook: loopbackio/loopback-datasource-juggler#599