Get rid of handler creation for each request. - #2
Merged
Conversation
raymondfeng
added a commit
that referenced
this pull request
Jul 2, 2013
Get rid of handler creation for each request.
Contributor
|
@ritch For the record, it works like a charm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another benefit of the new module approach is that we don't have to load handlers dynamically. This PR refactors the rest middleware to remove that behavior. Now a handler is created once and recreated only if the exported modules change. Eg. if you call
app.model().The reason why we need this behavior at all is because sl-remoting's rest adapter builds routes based on the remotes.exports object.
@Schoonology