Safer tests - step 1#2030
Merged
Merged
Conversation
If the supertest request fails its basic assertions, there may not even be a body to perform checks against, so bail early when possible.
bajtos
force-pushed
the
safer-tests-step1
branch
from
February 4, 2016 14:35
3dd7199 to
b0959b7
Compare
Contributor
|
@bajtos Sure I agree with land these change first :) |
Contributor
|
+1 for landing first. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the work on #1946 is taking quite long, I would like to land at least the original changes proposed by Ryan, as they are IMO clearly improving the test suite and I don't see any reason why they could not be landed even if they don't completely fix the CI.
/cc @rmg @jannyHou @richardpringle
Connect to strongloop-internal/scrum-loopback#651