Improve error message on connector init error#2105
Merged
Conversation
bajtos
force-pushed
the
fix/err-msg-on-connector-error
branch
from
February 26, 2016 13:46
e2a7f06 to
93d487f
Compare
Member
Author
|
@slnode test please |
| try { | ||
| var ds = dataSourcesFromConfig(name, config, this.connectors, this.registry); | ||
| this.dataSources[name] = | ||
| this.dataSources[classify(name)] = |
Member
Author
There was a problem hiding this comment.
I regret adding this code... :(
@ritch I think this particular line is safe to be removed in 3.0 - feel free to send a PR against loopback's master. Just add a short explanation to 3.0-RELEASE-NOTES.md as part of that patch.
Member
|
LGTM |
Member
Author
|
@slnode test please |
1 similar comment
Member
Author
|
@slnode test please |
bajtos
added a commit
that referenced
this pull request
Mar 2, 2016
Improve error message on connector init error
bajtos
added a commit
that referenced
this pull request
Mar 2, 2016
[back-port of pull request #2105]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, after adding a Cloudant-backed datasource to an app, node . will fail with
Now:
Requires loopbackio/loopback-datasource-juggler#859
/to @ritch please review