Skip to content

Replace all the "{href}" placeholders in verify email template - #2167

Closed
aitoraznar wants to merge 1 commit into
strongloop:masterfrom
aitoraznar:feature/verifyHref
Closed

Replace all the "{href}" placeholders in verify email template#2167
aitoraznar wants to merge 1 commit into
strongloop:masterfrom
aitoraznar:feature/verifyHref

Conversation

@aitoraznar

Copy link
Copy Markdown

Hello,

I needed to send an email with the link in a button and an alternative link in plain text.
So I used a regex to replace all the "{href}" placeholders in verify email template.

Regards

@slnode

slnode commented Mar 24, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@loay

loay commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

Can you please keep the commit message to 50 characters or less.
Also, do you mind adding a quick unit test to catch any future regression? Thanks

@aitoraznar

Copy link
Copy Markdown
Author

Ok, I''ll do

@ambrt ambrt mentioned this pull request May 8, 2016
@superkhau

Copy link
Copy Markdown
Contributor

Closing as duplicate of #2310 (already merged). If you feel the m modifier for regex is necessary, please submit another PR and I will get it merged in right away. Thanks for the contribution! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants