Backport/do not allow duplicate role names - #2296
Merged
Merged
Conversation
| // console.log('User: ', user.id); | ||
| Role.create({name: 'userRole'}, function(err, role) { | ||
| Role.create({ name: 'userRole' }, function(err, role) { | ||
| expect(err).to.exist; // jshint ignore:line |
Contributor
Author
There was a problem hiding this comment.
@bajtos Do you know if there is a better way to fix this (besides ...to.exist())?
superkhau
force-pushed
the
backport/do-not-allow-duplicate-role-names
branch
from
May 5, 2016 04:05
194338f to
7100c1a
Compare
| // console.log('User: ', user.id); | ||
| Role.create({name: 'userRole'}, function(err, role) { | ||
| Role.create({ name: 'userRole' }, function(err, role) { | ||
| expect(err).to.exist; //jshint ignore:line |
Contributor
Author
There was a problem hiding this comment.
@bajtos Do you know if there is a better way to fix this (besides ...to.exist())?
Member
There was a problem hiding this comment.
That's fine with me, just squash the commit adding this line with the one you are fixing.
I think we should fix our eslint-config-loopback to reject lines like expect(err).to.exist too.
Member
There was a problem hiding this comment.
I think we should fix our eslint-config-loopback to reject lines like
expect(err).to.existtoo.
Contributor
Author
|
@bajtos Review please. |
- Also fix jshint error in backported test
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
superkhau
force-pushed
the
backport/do-not-allow-duplicate-role-names
branch
from
May 5, 2016 17:52
7100c1a to
e89fbd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added jshint ignore line to make pass linting.