Avoid calling deprecated methds - #2560
Merged
Merged
Conversation
*Avoid calling deprecated `getHttpMethod` and `getFullPath`
Member
|
LGTM, We can always land #2435 on top of this quick fix, cannot we? Anyways, I'll leave the decision up to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Avoid calling deprecated
getHttpMethodandgetFullPathThis is the fix for deprecated messages. But please let me bring up the status of #2435 with Quentin in our group chat and if we are all good, we can land #2435 instead.
/to: @bajtos
Thanks!