Merged
Conversation
63 tasks
| app.boot = function(options) { | ||
| throw new Error( | ||
| '`app.boot` was removed, use the new module loopback-boot instead'); | ||
| g.f('{{`app.boot`}} was removed, use the new module loopback-boot instead')); |
Contributor
|
Two major rebase errors, the text in them is globalized properly however. Please fix those 2 and LGTM. |
0candy
force-pushed
the
backport/globalization
branch
4 times, most recently
from
22754fb to
a5c0b0b
Compare
|
|
||
| if (realmRequired && !query.realm) { | ||
| var err1 = new Error('realm is required'); | ||
| var err1 = new Error(g.f('realm is required')); |
Contributor
There was a problem hiding this comment.
What do you think about {{realm}}?
Contributor
|
LGTM except the one comment. |
0candy
force-pushed
the
backport/globalization
branch
6 times, most recently
from
840e5be to
b40a5f0
Compare
0candy
force-pushed
the
backport/globalization
branch
from
b40a5f0 to
3767940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of globalization
#2407
#2583