Skip to content

Expose upsertWithWhere - #2722

Merged
Amir-61 merged 1 commit into
2.xfrom
expose_upsertWithWhere_2.x
Sep 7, 2016
Merged

Expose upsertWithWhere#2722
Amir-61 merged 1 commit into
2.xfrom
expose_upsertWithWhere_2.x

Conversation

@Amir-61

@Amir-61 Amir-61 commented Sep 6, 2016

Copy link
Copy Markdown
Member
  • Expose upsertWithWhere

Backport of #2539

@Amir-61 Amir-61 added the #review label Sep 6, 2016
@Amir-61

Amir-61 commented Sep 6, 2016

Copy link
Copy Markdown
Member Author

@slnode test please

@Amir-61

Amir-61 commented Sep 6, 2016

Copy link
Copy Markdown
Member Author
  • @bajtos @rmg It seems Loopback@2.x does not fetch the latest changes from loopback-datasurce-juggler@2.x; in other words, it does not fetch the changes we have landed by this PR in loopback-datasurce-juggler@2.x; do we need to release a new npm version for loopback-datasurce-juggler@2.x to have the changes in this PR?
  • @bajtos @jannyHou When I test this PR using npm link to the latest commit of loopback-datasource-juggler@2.x on my local machine, all tests pass except this relationship test in test/relations.integration.js, which is definitely irrelevant to this PR. Can we merge this PR since the failure is irrelevant to this PR?

@Amir-61

Amir-61 commented Sep 6, 2016

Copy link
Copy Markdown
Member Author

Oh Please ignore my earlier comment#2722; it seems it started re-running tests now and they are pulling the latest changes from loopback-datsource-juggler@2.x this time; it seems they started passing now.

@bajtos There was some small merge conflicts. PTAL this back-porting PR. I see some failures (downstreams and some dependants), I do not think if they are relevant, am I right?

@Amir-61 Amir-61 self-assigned this Sep 6, 2016
@bajtos

bajtos commented Sep 7, 2016

Copy link
Copy Markdown
Member

LGTM.

@Amir-61
Amir-61 force-pushed the expose_upsertWithWhere_2.x branch from 9620ae6 to 614bf33 Compare September 7, 2016 16:24
@Amir-61
Amir-61 force-pushed the expose_upsertWithWhere_2.x branch from b3bd399 to 4c013de Compare September 7, 2016 16:42
@Amir-61
Amir-61 merged commit f741c1c into 2.x Sep 7, 2016
@Amir-61
Amir-61 deleted the expose_upsertWithWhere_2.x branch September 7, 2016 17:12
@Amir-61 Amir-61 removed the #review label Sep 7, 2016
@mountain1234585

Copy link
Copy Markdown

@Amir-61 Thanks a lot for getting this in.

@Amir-61

Amir-61 commented Sep 7, 2016

Copy link
Copy Markdown
Member Author

No Problem. Enjoy it 🎊 It will be available in the next NPM release.

@Amir-61

Amir-61 commented Sep 7, 2016

Copy link
Copy Markdown
Member Author

Relate to #2729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants