add allowArray to relations' 'create' remoteMethod#2947
Merged
Conversation
davidcheung
force-pushed
the
related-models-allow-array
branch
from
November 16, 2016 21:53
66883ec to
8357390
Compare
davidcheung
changed the title
accepted from model's remoteMethodaccepted from model's remoteMethod
Contributor
Author
|
@slnode test please |
davidcheung
force-pushed
the
related-models-allow-array
branch
from
November 18, 2016 15:30
8357390 to
9d0bb18
Compare
2 tasks
davidcheung
commented
Nov 21, 2016
| accepts: { arg: 'data', type: 'object', model: toModelName, http: { source: 'body' }}, | ||
| // retrieve original remoteMethod's arguments, so it properly inherits options | ||
| accepts: retrieveRemoteMethodInformation.call(this, toModelName, 'create') ? | ||
| retrieveRemoteMethodInformation.call(this, toModelName, 'create').accepts[0] : |
Contributor
Author
There was a problem hiding this comment.
@bajtos do you think it make sense to try to inherit the accept from the remoteClass, or its too much trouble for too little benefits?
we could also simply just add allowArray here
Member
There was a problem hiding this comment.
In this case, I would simply copy the allowArray flag. Relation methods are similar but not the same as original DAO methods. In the future, their REST API may diverge, in which case we would not want to share argument metadata.
Contributor
Author
|
@slnode test please |
1 similar comment
Contributor
Author
|
@slnode test please |
davidcheung
force-pushed
the
related-models-allow-array
branch
from
November 21, 2016 20:49
3052828 to
0f4bd37
Compare
davidcheung
changed the title
accepted from model's remoteMethod
gunjpan
reviewed
Nov 23, 2016
| .end(function(err, result) { | ||
| if (err) return done(err); | ||
| expect(result.body).to.have.property('id'); | ||
| expect(result.body).to.have.property('title', aPost.title); |
Contributor
There was a problem hiding this comment.
can this be changed to :
expect(result.body.title).to.eql(aPost.title)
Contributor
Author
There was a problem hiding this comment.
has discussion with @gunjpan decided to keep it the same
gunjpan
changed the title
gunjpan
approved these changes
Nov 23, 2016
this is needed because we added allowArray flag to persisted model's remoteMethod, but when relations try to rebuild such methods, it does not carry over such flags
davidcheung
force-pushed
the
related-models-allow-array
branch
from
November 23, 2016 17:10
0f4bd37 to
fa7cb92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connected to #2928
Description
this is a problem where relation's model's remoteMethods are rebuilt (not inherited).
Eg lets say
POST /book(book.create) has flag allowArrayPOST /Author/id/Bookwill rebuildremoteMethodper relation typeRelated issues
Checklist
guide
this is needed because we added allowArray flag to persisted model's
remoteMethod, but when relations try to rebuild such methods, it does
not carry over such flags
Update 16/11/16:
Update 17/11/16: