Check max password length in User.changePassword#3312
Merged
Conversation
superkhau
approved these changes
Mar 27, 2017
|
|
||
| // workaround for chai problem | ||
| // object tested must be an array, an object, or a string, | ||
| // but error given |
bajtos
force-pushed
the
fix/change-password-validation
branch
from
March 28, 2017 13:46
f8cc4ec to
b550cdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new
changePasswordAPI implemented by #3299 was not checking the maximum allowed password length, as added by #2580.This patch fixes
changePasswordto validate the password before making the change.Related issues
Checklist
guide