Skip to content

Add new event "remoteMethodAdded" - #3322

Merged
bajtos merged 1 commit into
strongloop:masterfrom
flvndvd:fix/nestRemotingRoutes
Mar 31, 2017
Merged

Add new event "remoteMethodAdded"#3322
bajtos merged 1 commit into
strongloop:masterfrom
flvndvd:fix/nestRemotingRoutes

Conversation

@flvndvd

@flvndvd flvndvd commented Mar 29, 2017

Copy link
Copy Markdown

Description

Add new event remoteMethodAdded triggered when nestRemoting is called

Related issues

#2409
strongloop/loopback-component-explorer#167

  • None

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode

slnode commented Mar 29, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

slnode commented Mar 29, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

3 similar comments
@slnode

slnode commented Mar 29, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Mar 29, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Mar 29, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

@flvndvd flvndvd mentioned this pull request Mar 29, 2017
Closed
2 tasks
@bajtos

bajtos commented Mar 30, 2017

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos bajtos changed the title Fix/nest remoting routes Add new event "remoteMethodAdded" Mar 30, 2017
@bajtos bajtos added the feature label Mar 30, 2017
@bajtos
bajtos requested review from kjdelisle and superkhau March 30, 2017 11:35
@bajtos

bajtos commented Mar 30, 2017

Copy link
Copy Markdown
Member

Thank you @DAVIDFlavien for the pull request. The changes looks mostly good to be. For completeness, could you please emit the new event from Model.remoteMethod too?

@bajtos
bajtos self-requested a review March 30, 2017 11:36
@bajtos bajtos self-assigned this Mar 30, 2017
@flvndvd

flvndvd commented Mar 30, 2017

Copy link
Copy Markdown
Author

Done in 8745f4e

bajtos
bajtos approved these changes Mar 31, 2017
View reviewed changes

@bajtos bajtos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flvndvd @bajtos
Add new event "remoteMethodAdded"
981bd30 
Emit a new method "remoteMethodAdded" whenever a new method is added,
typically when `Model.remoteMethod` or `Model.nestRemoting` is called.

The method is emitted both by the Model affected and the application
object.
@bajtos
bajtos force-pushed the fix/nestRemotingRoutes branch from 8745f4e to 981bd30 Compare March 31, 2017 13:33
@bajtos

bajtos commented Mar 31, 2017

Copy link
Copy Markdown
Member

@DAVIDFlavien thank you for the update. The patch LGTM now.

To speed up the process, I have squash all commits into a single one with a descriptive commit message following our 50/72 rule and git push -f into your feature branch.

This pull request can be landed once the CI builds are done.

@bajtos
bajtos merged commit 75fdd3c into strongloop:master Mar 31, 2017
@bajtos

bajtos commented Mar 31, 2017

Copy link
Copy Markdown
Member

Landed, thank you for the contribution! 🎉

@bajtos bajtos mentioned this pull request Apr 24, 2017
Closed
@sebastianfelipe

sebastianfelipe commented May 6, 2017 •
edited
Loading

Copy link
Copy Markdown

Is this gonna be in a new subversion soon? Need it please! Thanks 👍

@bajtos

bajtos commented May 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@sebastianfelipe I believe the feature was released in loopback@3.6.0.

@sebastianfelipe

sebastianfelipe commented May 24, 2017

Copy link
Copy Markdown

Thanks @bajtos, is there something for 2.X.X? I'm not using the latest version yet. I'd really appreciate it.

@bajtos

bajtos commented May 25, 2017

Copy link
Copy Markdown
Member

@sebastianfelipe 2.x is in LTS mode, we are no longer adding new features there. See https://loopback.io/doc/en/contrib/Long-term-support.html.

@sebastianfelipe

sebastianfelipe commented Aug 22, 2017

Copy link
Copy Markdown

I updated to this new release. I'm using the 3.9.0 version, but the nested models are not appearing in the explorer menu :/. It were created and I can visualize them using the Model.sharedClass._methods, but there doesn't appear in the explorer :/

@sebastianfelipe

sebastianfelipe commented Aug 22, 2017

Copy link
Copy Markdown

Adding to the previous situation, in the Model.sharedClass._methods, doesn't appear the direct prototype. methods to list them all at once (if there is a possibility to do it)

@bajtos

bajtos commented Aug 23, 2017

Copy link
Copy Markdown
Member

@sebastianfelipe Please open a new issue and provide us with a small app reproducing your problem, see http://loopback.io/doc/en/contrib/Reporting-issues.html#bug-report. Please mention my github handle @bajtos in the issue description, so that I receive a notification and can take a look.

@strongloop strongloop locked and limited conversation to collaborators Aug 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kjdelisle kjdelisle Awaiting requested review from kjdelisle
2 more reviewers
@bajtos bajtos bajtos approved these changes
@superkhau superkhau superkhau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flvndvd @slnode @bajtos @sebastianfelipe @superkhau