Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,13 @@ app.listen = function(cb) {

server.on('listening', function() {
self.set('port', this.address().port);
if (!self.get('url')) {
// A better default host would be `0.0.0.0`,
// but such URL is not supported by Windows
var host = self.get('host') || '127.0.0.1';
var url = 'http://' + host + ':' + self.get('port') + '/';
self.set('url', url);
}
});

var useAppConfig =
Expand Down
12 changes: 12 additions & 0 deletions test/app.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,18 @@ describe('app', function() {
});
});

it('updates "url" on "listening" event', function(done) {
var app = loopback();
app.set('port', 0);
app.set('host', undefined);

app.listen(function() {
expect(app.get('url'), 'url')
.to.equal('http://127.0.0.1:' + app.get('port') + '/');
done();
});
});

it('forwards to http.Server.listen on more than one arg', function(done) {
var app = loopback();
app.set('port', 1);
Expand Down