Skip to content

[2.0] Fix conflict resolution - #374

Merged
bajtos merged 2 commits into
2.0from
fix-conflict-resolution
Jul 15, 2014
Merged

[2.0] Fix conflict resolution#374
bajtos merged 2 commits into
2.0from
fix-conflict-resolution

Conversation

@bajtos

@bajtos bajtos commented Jul 15, 2014

Copy link
Copy Markdown
Member
  • fix typo models/changes causing a TypeError
  • automatically publish Change models to REST API

/to @ritch please review

The goal of this patch is to fix the replication for my Saturday's talk. I think it should be possible to get the conflict resolution working even without a public Change model, but I don't have time to investigate that at the moment.

Miroslav Bajtoš added 2 commits July 15, 2014 09:14
When a public model is added to an application and the model has change
tracking enabled, its Change model is added to the public models.

Before this change, conflict resolution in the browser was not working,
because it was not possible to fetch the remote change.
@ritch

ritch commented Jul 15, 2014

Copy link
Copy Markdown
Member

LGTM

bajtos added a commit that referenced this pull request Jul 15, 2014
@bajtos
bajtos merged commit b24d1e9 into 2.0 Jul 15, 2014
@bajtos
bajtos deleted the fix-conflict-resolution branch July 15, 2014 18:52
@bajtos

bajtos commented Jul 15, 2014

Copy link
Copy Markdown
Member Author

Released as 2.0.0-beta6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants