Support normalizeHttpPath - #433
Conversation
|
The patch LGTM, we should probably wait with the merge until a new version of strong-remoting is released. @fabien can you please rebase on the latest master and also sign the CLA using the new cla-hub based tool? Sorry for the hassle. |
|
@fabien ping, do you have time to finish this PR? |
|
I will when I return on monday. Please remind me if I forget.
|
There was a problem hiding this comment.
A nice to have feature: allow developers to turn on/off the flag normalizeHttpPath via server/config.json.
options = extend(this.get('remoting') || {}, options);
var remotes = this.remotes();
var handler = this._handlers[type] = remotes.handler(type, options);Usage in config.json:
{
"port": 3000,
"restApiRoot": "/api",
"remoting": {
"normalizeHttpPath": true
}
}@ritch @raymondfeng thoughts?
@fabien it's ok to leave this feature out of scope of this PR.
There was a problem hiding this comment.
nice to have feature: allow developers to turn on/off the flag normalizeHttpPath via server/config.json.
good idea 👍
There was a problem hiding this comment.
Let's move the implementation outside of this PR - see #608.
|
FWIW, the patch LGTM. |
When it's done, I'd like Jenkins to verify all tests passes and then the PR can be landed. |
|
@fabien ping |
fa3123a to
cf5c153
Compare
|
@bajtos ping |
There was a problem hiding this comment.
FWIW, I believe this line was removed from the current master.
|
I have rebased the patch on the current master, squashed commits, fixed coding style issues (mostly trailing spaces), added a descriptive commit message and landed as 568c866 |
|
This patch did not change |
4 participants
This options should probably become the default at some point (opt-out
instead of opt-in).
Thoughts on setting this globally (config.json) are welcome.
Mandatory PR: strongloop/strong-remoting#90