Conversation
19b64a4 to
a63511e
Compare
a63511e to
a5050bc
Compare
Member
|
@Setogit now that you are initializing strong-globalize/lib/globalize.js Lines 369 to 370 in 42400af global.STRONGLOOP_GLB = {
// ...
formatters: new MapCache(),
getHash: memoize(md5),
// ...
};Thoughts? |
Contributor
Author
|
@bajtos: right. it's not required. I kept it because I wanted to show the intended global.STRONGLOOP_GLB structure rather than hiding it in the lazy coding. But, not religious either; i don't mind replacing the two lines with comments. In general, I prefer documenting as code (including test code) to textual comments. |
This was referenced Sep 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect to #85