Detect strong-globalize in a shared module#92
Merged
Conversation
This was referenced Sep 7, 2016
bajtos
force-pushed
the
feature/detect-exports
branch
from
ed25310 to
06a0fb3
Compare
bajtos
changed the title
Member
Author
|
@Setogit I have cleaned up my patch. Could you please review? |
bajtos
force-pushed
the
feature/detect-exports
branch
3 times, most recently
from
85592ce to
16cf5f9
Compare
Improve lib/extract to support the following use case:
```js
// lib/globalize.js
var SG = require('strong-globalize');
SG.SetRootDir(path.join(__dirname, '..'), { autonomousMsgLoading: 'all'
});
module.exports = SG();
// lib/loopback.js
var g = require('./globalize');
// lib/registry.js
var g = require('./globalize');
// etc.
```
bajtos
force-pushed
the
feature/detect-exports
branch
from
16cf5f9 to
d5e9e03
Compare
Member
Author
|
Done, |
Member
Author
|
Considering that @Setogit is busy working on other priories, can perhaps one of you, @0candy @pthieu @kraman or @sam-github review this patch please? |
Contributor
|
@bajtos your use-case is compelling, I don't know the s-g code very well, I'll find time today to read through more closely. |
Contributor
|
LGTM |
Contributor
|
If it doesn't break anything, and makes things better for you, LGTM |
Member
Author
|
Released as |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I am extending the code detecting strong-globalize instances in the application code to support the use-case described in #87, which is
Connect to strongloop-internal/scrum-loopback#1044
See also #87
@Setogit please take a look
cc @0candy