Conversation
There was a problem hiding this comment.
That doesn't make sense to me. This is the documentation string that will show up in the explorer.
- did you test this works?
- since almost all the API is defined by JSON files, and they are not translated, won't this be bizarre even if it does work, to have an almost entirely English explorer, with only the remote methods have localized string descriptions?
There was a problem hiding this comment.
The unit test passed up to the point master passes locally on my OSX.
strong-mesh-models globalization depends on loopback/explorer globalization strategy which is open at the moment.
|
@sl-node test please |
There was a problem hiding this comment.
--help needs protection from translation
|
@sl-node test please |
|
All windows builds failed. The other builds succeeded. |
be4eaba to
0c165f0
Compare
|
This requires strongloop/strong-globalize#5 |
|
@sl-node test please |
There was a problem hiding this comment.
@Setogit I don't understand this change.
After globalization, are there no longer quotes around "service 1"?
|
Closing as abandoned |
3 participants
connect to strongloop-internal/scrum-nodeops#1157