Not possible to set `shared=false` on resolved methods

[STRML]

This is related to strongloop/loopback#477.

This line makes it impossible to disable relation REST methods, as new SharedMethods are created each time ModelClass.methods() is called, ensuring that all relation methods will have shared=true.

Ideally, the shared property would be removed or be moved to a getter, and methods() would check a user-provided whitelist (default: all methods). The current recommendation of using ModelClass.sharedClass.find(fn, isShared).shared = false is not only leaky but not guaranteed to work.

[raymondfeng]

@ritch Any insights? I think we need to have symmetric method to remoteMethod on the model class to disable remoting. The method name can point to a real method or relation/scope name.

[clark0x]

There is another reason. Try this model (require to add some relations in model's JSON config ):

module.exports = function (Question) {
  Question.once('attached', function (app) {
    var methods = Question.sharedClass.methods();
    console.log('attached:' + methods.length); // 13
  };
  Question.once('dataSourceAttached', function (Question) {
    var methods = Question.sharedClass.methods();
    console.log('dataSourceAttached:' + methods.length); // 13
  };
  var methods = Question.sharedClass.methods();
  console.log('custom:' + methods.length); // 12
});

That means, there is no way to access any shared method that is dynamically defined.

[clark0x]

@STRML @raymondfeng @ritch I have made a patch for this issue: #95

ModelClass.sharedClass.find(fnOrName, isStatic).shared = false now works for all kinds of shared methods, but it must be executed after all related models attached to data sources (Because relations might be loaded after attached and dataSourceAttached are emitted). Hence, it will not work if it's in model's script file. Currently, I create a boot script to do such things.

[ritch]

@clarkorz see this proposal for a hook that will ensure the model is setup

[STRML]

Is this fixed via Model.disableRemoteMethod?

[ritch]

Yep