WIP: GoDaddy Contributions - #110
Closed
shelbys wants to merge 27 commits into
Closed
Conversation
* upstream/master: Bump version and update deps Skip properties that are shared model classes Fix typo Fix typo in doc link Conflicts: package.json
…der to support reverse-proxy from https to http
* upstream/master: 2.0.3 Improve shared class and method docs Bump version Provide an option to configure if stack trace should be disabled Remove stack traces from production errors. Update test case to remove usage of deprecated express apis 2.0.1 rest: fix RestMethod.isReturningArray 2.0.0 Remove ext/swagger 2.0.0-beta4 2.0.0-beta3 Exclude body-parser from the browser bundle Remove duplicate dep Bump version Add more tests and use eql for readability Add more comments Sort the routes so that methods can be resolved in order Upgrade to express 4.x Conflicts: ext/swagger.js package.json test/swagger.test.js
* upstream/master: Fix the broken sample
…ns as array with root=true
Upgraded to v2 and ported changes from fork
… in order to replace restErrorHandler
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
* upstream/master: (30 commits) Update contribution guidelines 2.4.0 Add sharedClass.disableMethod() 2.3.0 Add prototype shared method tests Fix http-invocation test Support prototype methods via HttpInvocation 2.2.2 Remove stupid assert global Fix missing assert Bump version Set up CORS hander for error responses Bump version Add a test for request header param Allows implicit header param 2.1.1 Check the name type Add support for header param Allow args of complex type without validation Implement normalizeHttpPath ... Conflicts: lib/http-context.js package.json
…mber, and string when delimited with , or |
Member
|
All the changes listed in the description sound great. |
Contributor
Author
There was a problem hiding this comment.
@ritch - I vaguely remember there being a reason Array.isArray() didn't work, but I can't remember for sure now
Member
|
Moving this into smaller pull requests so we can land features that look good already. |
This was referenced Oct 10, 2014
Member
|
@ritch please cross-link the smaller pull requests to this PR for posterity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broader and deeper support for Swagger capabilities, including 1.2
Upgraded to generate specs based on Swagger 1.2
Add indication of response being a collection
Added description for 200 responseMessage
Added missing docs for errors and notes
Added support for automatically re-joining long strings split into arrays in specs for description, notes, and message values
Added support for errors property to specify possible errors that can be returned
Added support for multiple responseMessages from Swagger 1.2
Added support for notes per API
Added support for primitives in StatusCodeView
Added support for return types as Arrays instead of Strings
Avoid adding empty description for each API
Changed to possibly pull model description from ctor.settings
Corrected addDynamicBasePathGetter() to honor x-forwarded-proto in order to support reverse-proxy from https to http
Corrected default for consumes+produces
Corrected generateModelDefinition() to scan for model references in nested models, remote returns, and errors
Corrected prepareDataType() to handle collections and nesting, and changed to always and only use responseMessages
Automatic conversion of response bodies to XML, when requested via Accept: header
Added error-handling when unable to generate XML
Added support for automatically converting to XML, if requested via Accept
Better support for alternate Content-Types
Configured pretty-printing and date conversion to ISO for XML responses
Corrected XML handling when root is an Array