update check for turning off sloppy coercion when body request is application/json - #266
Closed
ebourmalo wants to merge 2 commits into
Closed
update check for turning off sloppy coercion when body request is application/json#266ebourmalo wants to merge 2 commits into
ebourmalo wants to merge 2 commits into
Conversation
Check if the content-type request header in an application/json type. Allow now the charset definition (i.e 'application/json;charset=UTF-8')
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
ebourmalo
changed the title
|
👍 |
Member
|
@slnode ok to test |
Member
|
Hello @ebourmalo, sorry for taking so long to respond. Could you please rebase your patch on top of the current master and add a unit-test to demonstrate your code works as intended and prevent regressions in the future? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Member
|
@slnode ok to test |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Member
|
Closing in favour of #350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check and fix if the content-type header is an application/json request type.
Allow now the charset definition in the content-type (i.e 'application/json;charset=UTF-8').
Connect to #267