To allow user to customize the root element of xml output

[davidcheung]

To take wrapperElement as an option in remoteMethod setup

{
  returns: { 
    root: true,
      xml: {wrapperElement: 'a'}
    },
    http: { path: '/' }
}

Objective is to allow user to produce output as follow

<a>1</a>

Fixes #262

connected to /issues/262

[davidcheung]

@bajtos when input is string, js2xmlparser gets syntax error, then try catch block from sendBodyXml() throws 500 , should we modify the data so it doesn't internal server error? or should we not let user pass in just one string. (We do modify the data when passed as array)

[davidcheung]

also added declaration=false flag

{
  "returns": { 
    "root": true,
    "xml": { "declaration": false }
  },
  "http": { "path": "/" }
}

to not include the declaration of

<?xml version="1.0" encoding="UTF-8"?>

To address this https://github.com/strongloop-internal/scrum-cs/issues/396

Everytime I return something like:

cb(null, '{a:blah}');

I receive xml like: <response><a>blah</a></response>
But what I want is xml like: <a>blah</a>

@bajtos, @ritch not sure if this feature is needed, and not sure where to add documentation for such, any advice?

[ritch]

To address this strongloop-internal/scrum-cs#396

I don't think this exactly addresses the issue, but it might be a welcome feature.

[ritch]

use typeof input not typeof(input)

[davidcheung]

@ritch, I have addressed the 2 suggestions you made, please review

[davidcheung]

@bajtos review please :)

[davidcheung]

@slnode test please

[bajtos]

AFAICT, this is adding another feature, which is to allow the developer to specify whether XML declaration is included in the response. I can live with the fact that it's introduced together with other changes, but please add a unit-test to verify.

[davidcheung]

Unit-test added.

[bajtos]

@davidcheung reviewed, see my comments above.

[davidcheung]

hi @bajtos, have added unit test for the changes. Please review again :)

[bajtos]

Please modify the test to use a custom root element, e.g. <text> instead of <response>.

[bajtos]

@davidcheung great, this is almost ready. Please address my comments above and squash the commits into a single one. Make sure the commit message mentions all new features (declaration: false, wrapperElement: 'name').

[davidcheung]

@bajtos i have addressed the comments above, I believe the PR is good to go. Please review again

[bajtos]

...xml declaration..., not decoration.

[bajtos]

@slnode test please

[bajtos]

@davidcheung I have fixed the test name myself and improved the commit message a bit. The patch LGTM, I'll land it as soon as I get CI build results.