Fix problem afterError always called

[florianorpeliere]

Hello everyone.

I seem to have found a bug in version 2.25.
Indeed, the afterError hook is always called even if there is no error.
https://github.com/strongloop/strong-remoting/blob/2.x-latest/lib/remote-objects.js#L680
In fact, triggerErrorAndCallBack method is always called because phases.run use async.eachSeries and the documentation explain

each(arr, iterator, [callback])
callback(err) - Optional A callback which is called when all iterator functions have finished, or an error occurs.

In version 2.24 we had this
https://github.com/florianorpeliere/strong-remoting/blob/4d965966f4b860c27a6a42c421c7ea7e9d3696f5/lib/remote-objects.js#L625

So I allowed myself to put this piece of code in a method.
I do not know if the name really fits .

As this is my first contribution , please be indulgent .
Hoping to have helped you .

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[bajtos]

@slnode ok to test

[bajtos]

@florianorpeliere ouch, thank you for reporting the problem and sending a pull request to fix it.

Could you please add a unit-test to verify your change? The test should fail with the current implementation and pass with your proposed change in place.

[bajtos]

@florianorpeliere I landed a fix myself via #283 to get this regression fixed ASAP.

[florianorpeliere]

@bajtos Okay no problem. Sorry I forgot the unit test.
But happy to have helped you.