Skip to content

Backport of #329#330

Merged
0candy merged 1 commit into2.xfrom
backport/globalization
Aug 9, 2016
Merged

Backport of #329#330
0candy merged 1 commit into2.xfrom
backport/globalization

Conversation

@0candy
Copy link
Copy Markdown
Contributor

@0candy 0candy commented Aug 9, 2016

Globalization of strong-remoting 2.x
#329

@0candy 0candy self-assigned this Aug 9, 2016
@0candy 0candy added the #review label Aug 9, 2016
@0candy 0candy added this to the #Epic: Globalization milestone Aug 9, 2016
@0candy
Copy link
Copy Markdown
Contributor Author

0candy commented Aug 9, 2016

@superkhau PTAL

Comment thread package.json Outdated
"qs": "^2.4.2",
"request": "^2.55.0",
"sse": "0.0.6",
"strong-error-handler": "^1.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@superkhau
Copy link
Copy Markdown
Contributor

@0candy Mostly good xcept the strong-error-handler, remove and LGTM. No more review needed. 🚢

@0candy 0candy force-pushed the backport/globalization branch from f743cd3 to 7795898 Compare August 9, 2016 19:46
@0candy 0candy force-pushed the backport/globalization branch from 7795898 to 0c72598 Compare August 9, 2016 19:56
@0candy 0candy merged commit 028b0e3 into 2.x Aug 9, 2016
@0candy 0candy removed the #review label Aug 9, 2016
@0candy 0candy deleted the backport/globalization branch August 9, 2016 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants