Skip to content

Fix query string to have null #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kobaska wants to merge 2 commits into from
Closed

Fix query string to have null #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765ede6
Handling null value in query
kobaska Oct 26, 2016
95b96ff
Using JSON stringify instead of qs
kobaska Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/http-invocation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ var assert = require('assert');
var request = require('request');
var Dynamic = require('./dynamic');
var SUPPORTED_TYPES = ['json', 'application/javascript', 'text/javascript'];
var qs = require('qs');
var urlUtil = require('url');
var ReadableStream = require('stream').Readable;
var MuxDemux = require('mux-demux');
Expand Down Expand Up @@ -212,7 +211,11 @@ HttpInvocation.prototype.createRequest = function() {
}

if (query) {
req.url += '?' + qs.stringify(query);
var urlParams = Object.keys(query).map(function(key) {
return key + '=' + JSON.stringify(query[key]);
}).join('&');

req.url += '?' + encodeURI(urlParams);
}

return req;
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"js2xmlparser": "^1.0.0",
"loopback-phase": "^1.3.0",
"mux-demux": "^3.7.9",
"qs": "^6.2.1",
"request": "^2.55.0",
"sse": "0.0.6",
"strong-globalize": "^2.6.6",
Expand Down