Skip to content

Stringify query params which are objects as JSON [2.x]#381

Merged
gunjpan merged 1 commit into
strongloop:2.xfrom
horiaradu:2.x
Nov 3, 2016
Merged

Stringify query params which are objects as JSON [2.x]#381
gunjpan merged 1 commit into
strongloop:2.xfrom
horiaradu:2.x

Conversation

@horiaradu

Copy link
Copy Markdown
Contributor

This is a backport of this PR: #325. I've cherrypicked the commit and so I've added the refactorings which were made in the test file as well.

@gunjpan - check it out :)

@slnode

slnode commented Nov 1, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

slnode commented Nov 1, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments
@slnode

slnode commented Nov 1, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Nov 1, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@gunjpan

gunjpan commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

@slnode ok to test

@gunjpan gunjpan self-assigned this Nov 1, 2016
@gunjpan

gunjpan commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

@horiaradu : Change LGTM. Could you please update commit message to say: backport of PR#325
For example, PTAL at this: https://github.com/strongloop/loopback/pull/2782/commits

@horiaradu horiaradu changed the title Stringify query params which are objects as JSON Stringify query params which are objects as JSON [2.x] Nov 1, 2016
@gunjpan

gunjpan commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

@horiaradu : Thank you for updating the commit message, but now it breaks the CI with:

Linting commit logs
**
**  1 problems found:
**    2323ddc - Stringify query params which are objects as JSON [2: First line should be 50 characters or less (saw 54)

Also, backport of #<PR number> should be a PR #325, instead of the issue where it was reported as bug.
Could you please fix it. Thank you.

Stringify query params which are objects in a way in which empty ararys
and null values are preserved instead of removed
(default querystring implementation).

backport of: #325
@gunjpan
gunjpan merged commit 2db3cfe into strongloop:2.x Nov 3, 2016
@gunjpan

gunjpan commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

@horiaradu: Landed. Thank you for the PR and keeping up with change requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants