Skip to content

feat: VersionIcon fixes and improvements#6

Open
DanielCech wants to merge 4 commits intomasterfrom
feat/dc/fixes-and-improvements
Open

feat: VersionIcon fixes and improvements#6
DanielCech wants to merge 4 commits intomasterfrom
feat/dc/fixes-and-improvements

Conversation

@DanielCech
Copy link
Copy Markdown
Member

@DanielCech DanielCech commented Apr 28, 2026

Summary

Modernizes VersionIcon to work with real asset catalogs instead of a hardcoded legacy icon list, adds configurable error handling with --onError fail|warn, and refactors the implementation into smaller support files for maintainability.

Changes

  • Discover and process icon variants from Contents.json dynamically
  • Resolve Info.plist and icon asset paths more reliably across projects
  • Add --onError fail|warn to allow non-blocking builds when desired
  • additional parameter --titleRotation.
  • new --versionStyle values
  • Improve test coverage, including a Flashcards-style asset catalog case
  • Split the old monolithic implementation into focused support files

Verification

  • swift test passes

@DanielCech DanielCech marked this pull request as ready for review April 28, 2026 16:05
@DanielCech DanielCech requested review from arkhigleb and ipek April 29, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant