Superlinter latest version#22
Draft
ozanborafikir wants to merge 23 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change(s) does your PR add?
Currently, we are using
super-linter/super-linter/slim@v6.8.0in our linter workflow which by default includes PHP 8.3 and outdatedPHPStan - PHP Static Analysis Tool 1.11.2version.With PHP 8.4 Upgrade in Domain API we need to rely on PHP 8.4 and
PHPStan - PHP Static Analysis Tool 2.1.49. To accommodate these versions, this PR changes super-linter version to the latest which has PHP 8.4 andPHPStan - PHP Static Analysis Tool 2.1.37support.The order of the linter runners is also changed. Previously we were running PHPMD in the first place with only the changed files. However, we already fixed existing issues in the repositories, so there is no longer an issue to run in the entire codebase. We expect to have a
phpmdscript available in the composer.json.We need to run the super-linter first, because it is looking for composer files recursively in the workspace. And it tries to install composer files within the vendor directory if the composer is already run.
How did you test your change(s)?
Tested on Domain API PRs.
What do you want feedback on?
This change will lead us to update the linter workflows in all repositories. Do you think it is a problem?
Relevant contextual information?
e.g. documentation/diagrams