Skip to content

chore: update lsp dependencies#1933

Merged
hugoclrd merged 10 commits intomainfrom
chore/update-lsp-dependencies
Jul 25, 2025
Merged

chore: update lsp dependencies#1933
hugoclrd merged 10 commits intomainfrom
chore/update-lsp-dependencies

Conversation

@hugoclrd
Copy link
Contributor

Description

Part of a continous effort to improve our dependencies maintenance and reduce the size of Clarinet.
This espeically removes tower@0.4, while tower@0.5 was already part of the dependency tree

Update:

Breaking change:

  • lsp-types 0.97 now relies on fluent_uri::Uri insteal of Url
    • this change, again, surfaces the need to fully refactor our FileLocation struct

@hugoclrd hugoclrd requested review from jbencin and tippenein and removed request for jbencin July 25, 2025 11:10
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarinet-cli/src/lsp/mod.rs 0.00% 2 Missing ⚠️
components/clarity-lsp/src/common/backend.rs 95.65% 2 Missing ⚠️
components/clarinet-cli/src/lsp/native_bridge.rs 0.00% 1 Missing ⚠️
components/clarity-lsp/src/utils/mod.rs 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hugoclrd hugoclrd marked this pull request as draft July 25, 2025 12:58
@hugoclrd hugoclrd removed request for jbencin and tippenein July 25, 2025 13:17
@jbencin
Copy link
Contributor

jbencin commented Jul 25, 2025

It looks like you are reverting my changes from #1859. These were necessary to get the Native LSP (which uses the FileLocation::FileSystem type for files) working. Unless something has changed in tower-lsp's URL parsing, and it can now handle URL's without the file:// prefix, this will break the Native LSP

@hugoclrd hugoclrd force-pushed the chore/update-lsp-dependencies branch 2 times, most recently from f83350f to 3e43db9 Compare July 25, 2025 15:24
@hugoclrd hugoclrd force-pushed the chore/update-lsp-dependencies branch from 3e43db9 to 8edbcf9 Compare July 25, 2025 15:41
@hugoclrd hugoclrd marked this pull request as ready for review July 25, 2025 15:42
@hugoclrd hugoclrd requested a review from jbencin July 25, 2025 15:42
hugoclrd and others added 3 commits July 25, 2025 18:13
@hugoclrd hugoclrd force-pushed the chore/update-lsp-dependencies branch 2 times, most recently from b0bf264 to 49eb893 Compare July 25, 2025 17:16
@hugoclrd hugoclrd force-pushed the chore/update-lsp-dependencies branch from 49eb893 to a967f33 Compare July 25, 2025 17:27
@hugoclrd hugoclrd requested a review from jbencin July 25, 2025 17:28
@hugoclrd hugoclrd enabled auto-merge (squash) July 25, 2025 17:45
@hugoclrd hugoclrd merged commit b447101 into main Jul 25, 2025
25 checks passed
@hugoclrd hugoclrd deleted the chore/update-lsp-dependencies branch July 25, 2025 18:35
@hugoclrd hugoclrd mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants