Refine PR merge and branch update permissions#114
Merged
stylessh merged 3 commits intoApr 14, 2026
Conversation
Owner
|
Fantastic @kovsu, will review later |
stylessh
approved these changes
Apr 14, 2026
stylessh
added a commit
that referenced
this pull request
Apr 18, 2026
* Refine PR merge and branch update permissions * show/hide bypass check based on met criterias --------- Co-authored-by: Alan Daniel <stylesshjs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The merge status card shows the merge button to all users regardless of their repository permissions. Users without write access see an active merge button that only fails server-side on click. This PR adds a
canMergepermission check so the UI disables the button upfront and shows a clear message.Also fixes
canUpdateBranchto account for PR authorship — the PR author can update their own branch without needing push access to the base repo.Changes
canMergefield computed from repository permissions (push/admin) incomputePullStatuscanUpdateBranchto also allow PR authors to update their own branchTest Plan
Screenshots