Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build-logic/src/main/resources/substrait-pmd.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
<rule ref="category/java/bestpractices.xml/UnusedPrivateField" />
<rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />
<rule ref="category/java/design.xml/AvoidThrowingRawExceptionTypes" />
<rule ref="category/java/errorprone.xml/MissingSerialVersionUID" />
</ruleset>
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
public interface ParameterizedType extends TypeExpression {

class RequiredParameterizedVisitorException extends RuntimeException {

private static final long serialVersionUID = 5009974222890249956L;

@Override
public synchronized Throwable fillInStackTrace() {
return this;
Expand Down
4 changes: 3 additions & 1 deletion core/src/main/java/io/substrait/function/TypeExpression.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
@Value.Enclosing
public interface TypeExpression {

class RequiredTypeExpressionVisitorException extends RuntimeException {}
class RequiredTypeExpressionVisitorException extends RuntimeException {
private static final long serialVersionUID = 8381558691397737963L;
}

<R, E extends Throwable> R accept(final TypeVisitor<R, E> typeVisitor) throws E;

Expand Down
2 changes: 2 additions & 0 deletions core/src/main/java/io/substrait/type/Deserializers.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public class Deserializers {

public static class ParseDeserializer<T> extends StdDeserializer<T> {

private static final long serialVersionUID = 2105956703553161270L;

private final BiFunction<String, SubstraitTypeParser.StartContext, T> converter;

public ParseDeserializer(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ public void syntaxError(
}

public static class ParseError extends RuntimeException {

private static final long serialVersionUID = -6831467523614033666L;

public ParseError(final String message, final Throwable cause) {
super(message, cause);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ private static Object valGenerator(Class<?> type) {

// Class used to propagate type generation errors from param generator to test cases
private static class UnsupportedTypeGenerationException extends Exception {

private static final long serialVersionUID = -8627552468610061245L;

public UnsupportedTypeGenerationException(String s) {
super(s);
}
Expand Down