Conversation
```
def test_with_ruby_asan
puts 'insert with prepared statement and select'
db = DuckDB::Database.open
con = db.connect
con.execute('CREATE TABLE test (id INTEGER PRIMARY KEY, name VARCHAR(100))')
stmts = DuckDB::ExtractedStatements.new(con, "INSERT INTO test VALUES (1, 'hello')")
stmts.each do |stmt|
stmt.execute
stmt.destroy
end
result = con.execute('SELECT * FROM test WHERE id = ?', 1)
end
```
This reverts commit f5f026a.
This reverts commit dbe82f2. ``` def test_with_ruby_asan db = DuckDB::Database.open con = db.connect con.execute('CREATE TABLE test (id INTEGER PRIMARY KEY, name VARCHAR(100))') con.execute("INSERT INTO test VALUES (1, 'hello')") puts 'ExtractedStatements#each with PreapredStatement#(execute|destroy)' stmts = DuckDB::ExtractedStatements.new(con, "INSERT INTO test VALUES (1, 'hello')") stmts.each do |stmt| stmt.execute stmt.destroy end result = con.execute('SELECT * FROM test WHERE id = ?', 1) end ```
This reverts commit f22dd50.
|
Caution Review failedThe pull request is closed. WalkthroughA new GitHub Actions workflow has been introduced to automate testing for a Ruby project using AddressSanitizer (ASan) on Ubuntu. The workflow tests the project against multiple DuckDB versions (1.1.3, 1.1.1, 1.0.0) and includes steps for code checkout, Ruby setup, DuckDB caching, dependency installation, and test execution. Additionally, changes were made to the prepared statement initialization in the C extension and a new test method was added to validate ASan functionality. Changes
Sequence DiagramsequenceDiagram
participant GA as GitHub Actions
participant Ruby as Ruby Environment
participant DuckDB as DuckDB Build
participant Test as Test Suite
GA->>Ruby: Set up Ruby version
GA->>DuckDB: Cache or Build DuckDB
Ruby->>Test: Install dependencies
Ruby->>Test: Build with/without deprecated API
Test->>DuckDB: Prepare and execute statements
GA->>Test: Run tests with ASan
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Owner
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try using ruby-asan CI test
Summary by CodeRabbit
New Features
Improvements
Chores