fix: support Python 3.14 annotations in assign_attr_with_json#69
Open
stefefn wants to merge 1 commit into
Open
fix: support Python 3.14 annotations in assign_attr_with_json#69stefefn wants to merge 1 commit into
stefefn wants to merge 1 commit into
Conversation
Python 3.14 (PEP 649) no longer populates cls.__dict__["__annotations__"] for lazily-evaluated annotations, causing a KeyError when loading drafts. Replace the manual __dict__ lookup with inspect.get_annotations(cls), which works correctly across Python 3.10+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Python 3.14, saving a draft crashes with KeyError fps inside assign_attr_with_json in pyJianYingDraft/util.py.
Python 3.14 introduced deferred annotation evaluation (PEP 649), which means class-level annotations are no longer automatically stored in cls.dict. The existing code relied on this, so type_hints was always empty and any attribute lookup raised a KeyError.
Fix
Replace the manual dict loop with inspect.get_annotations(cls), which is the correct cross-version API for reading class annotations. inspect was already imported in the file so no new dependency is needed.
Testing
Verified on Python 3.14.4 (WSL/Ubuntu). Draft creation, add_video, and save_draft all complete successfully after the fix.