Merged
Conversation
|
Hello @vatch123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-08-23 16:36:13 UTC |
|
Thanks for the pull request @vatch123! Everything looks great! |
wafels
reviewed
Jun 3, 2019
wafels
reviewed
Jun 3, 2019
wafels
reviewed
Jun 3, 2019
wafels
reviewed
Jun 3, 2019
wafels
reviewed
Jun 6, 2019
nabobalis
reviewed
Jun 6, 2019
Member
|
I think the occult code should be in a new file called trace or something better. |
nabobalis
force-pushed
the
occult
branch
13 times, most recently
from
4135e03 to
bd3be60
Compare
wafels
reviewed
Aug 22, 2019
Member
|
pep8speaks is complaining, any chance you can look into them and fix it? |
Member
|
Approved. |
wafels
approved these changes
Aug 23, 2019
Cadair
approved these changes
Aug 27, 2019
Member
Cadair
left a comment
Cadair
left a comment
There was a problem hiding this comment.
Looks fine to me after a brief check
Member
|
Thanks everyone for the reviews and @vatch123 for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The python version of the occult2.
TODO:
Fixes #9