Skip to content

Added the example to remove cosmic ray hits#35

Merged
nabobalis merged 17 commits intosunpy:masterfrom
vatch123:master
Aug 7, 2019
Merged

Added the example to remove cosmic ray hits#35
nabobalis merged 17 commits intosunpy:masterfrom
vatch123:master

Conversation

@vatch123
Copy link
Contributor

@vatch123 vatch123 commented Jun 27, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jun 27, 2019

Hello @vatch123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:101: E501 line too long (123 > 100 characters)
Line 8:101: E501 line too long (101 > 100 characters)
Line 19:101: E501 line too long (159 > 100 characters)
Line 50:101: E501 line too long (139 > 100 characters)
Line 61:101: E501 line too long (110 > 100 characters)

Comment last updated at 2019-08-07 16:00:10 UTC

@ghost
Copy link

ghost commented Jun 27, 2019

Thanks for the pull request @vatch123! Everything looks great!

@vatch123
Copy link
Contributor Author

This is odd why my previous commits are showing here!! Though the files changed are the only 3.

@nabobalis
Copy link
Member

Im not sure. You probably need to make sure your local remotes are up to date.

git remote update
then do
git rebase -i upstream/master

@nabobalis nabobalis added this to the v0.1.0 milestone Jun 27, 2019
@nabobalis
Copy link
Member

The function has done very little in the last example. This is due to the JP2 source?

@vatch123
Copy link
Contributor Author

The function has done very little in the last example. This is due to the JP2 source?

Yes probably due to that.

vatch123 and others added 2 commits June 28, 2019 22:16
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Copy link
Member

@nabobalis nabobalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and I think it's good to go.

Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
@nabobalis
Copy link
Member

Thanks @vatch123

@nabobalis nabobalis merged commit a0315b2 into sunpy:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants