Merged
Conversation
…aster branch and recommiting to solve merge conflicts
…or references. Other small changes. No changes to algorithms themselves, as was suggested by @dpshelio
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
|
Hello @vatch123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-08-21 08:17:17 UTC |
|
Thanks for the pull request @vatch123! Everything looks great! |
nabobalis
reviewed
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the PR #22. Fixed the variable names as mentioned in the comments on that thread. No implementation related changes have been made apart from the fact that the
test_noise.pynow uses pytest. The comments which required knowledge of implementation have been left as it is.Fixes #18