Skip to content

Noise#38

Merged
nabobalis merged 32 commits intosunpy:masterfrom
vatch123:noise
Aug 21, 2019
Merged

Noise#38
nabobalis merged 32 commits intosunpy:masterfrom
vatch123:noise

Conversation

@vatch123
Copy link
Contributor

Description

Continuation of the PR #22. Fixed the variable names as mentioned in the comments on that thread. No implementation related changes have been made apart from the fact that the test_noise.py now uses pytest. The comments which required knowledge of implementation have been left as it is.

Fixes #18

m-squared96 and others added 29 commits April 3, 2019 23:40
…aster branch and recommiting to solve merge conflicts
…or references. Other small changes. No changes to algorithms themselves, as was suggested by @dpshelio
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>
@pep8speaks
Copy link

pep8speaks commented Aug 20, 2019

Hello @vatch123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:101: E501 line too long (104 > 100 characters)
Line 41:101: E501 line too long (103 > 100 characters)
Line 80:5: E722 do not use bare 'except'
Line 153:21: E203 whitespace before ':'
Line 158:18: E203 whitespace before ':'
Line 193:58: E231 missing whitespace after ','
Line 197:34: E203 whitespace before ':'
Line 266:27: E203 whitespace before ':'
Line 288:101: E501 line too long (101 > 100 characters)
Line 295:21: E203 whitespace before ':'
Line 300:18: E203 whitespace before ':'
Line 334:28: E203 whitespace before ':'
Line 334:55: E203 whitespace before ':'

Comment last updated at 2019-08-21 08:17:17 UTC

@ghost
Copy link

ghost commented Aug 20, 2019

Thanks for the pull request @vatch123! Everything looks great!

@nabobalis nabobalis added this to the v0.1.0 milestone Aug 20, 2019
@nabobalis nabobalis added [Review] Feature Request New feature wanted. labels Aug 20, 2019
@nabobalis nabobalis merged commit fbf6a19 into sunpy:master Aug 21, 2019
@vatch123 vatch123 deleted the noise branch August 21, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Request New feature wanted. [Review]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

De-Class NoiseLevelEstimation

4 participants