Conversation
fspijkerman
force-pushed
the
feature/keycloak-provider
branch
from
35fb34e to
baa85c5
Compare
|
Hey @fspijkerman, Thanks for the PR! We will review it shortly. Could we trouble you to add documentation on how to use the provider as well? Links Documentation repo: https://github.com/supabase/supabase/tree/master/web/docs/guides/auth Example of provider documentation: https://supabase.com/docs/guides/auth/auth-google Feel free to let us know if you need any help with this! |
No problem, I will also update |
|
Ok, thanks! No rush, let us know whenever ready :) |
ismael-iskauskas
left a comment
ismael-iskauskas
left a comment
There was a problem hiding this comment.
The code looks fine. Compared it with other Oauth Providers
|
Meanwhile I have been working on the documentation, but in order to finish a full example (like other providers) it also requires some changes in gotrue-js (already prepared). Will make a PR for this too. |
kangmingtay
left a comment
kangmingtay
left a comment
There was a problem hiding this comment.
Hey @fspijkerman, thanks for the PR! I'm not too familiar with how keycloak works but based on the documentation it seems like a single application can have multiple realms to manage different groups of users.
I would expect the ext.URL to include the /realms/{realm-name}/, does this mean that "Sign-in with keycloak" on gotrue would be limited to a single realm?
Yes thats correct (and normal), keycloak is multitenant via its Realms. In most cases only 1 realm is used per application, per realm is possible to have multiple applications. |
|
Hey @fspijkerman, thanks for making the changes, i want to merge this in but i would like to test out your changes with keycloak running locally first. Do you have a guide that I can follow for obtaining the client_id and client_secret in keycloak? We would want to have some documentation around setting this up as well (similar to the rest of the providers) |
|
🎉 This PR is included in version 2.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
* Keycloak OAuth Provider * Update README.md * Removed the usage of chooseHost to keep things clear * Allow to use the Keyloak provider in an ID Token grant flow * fix tests Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
4 participants
What kind of change does this PR introduce?
This adds a new OAuth Provider
What is the current behavior?
No support for Keycloak OAuth
What is the new behavior?
Support for Keycloak using OAuth