fix: update user email should not fail when current email doesn't exist#408
Merged
kangmingtay merged 6 commits intomasterfrom Mar 8, 2022
Merged
fix: update user email should not fail when current email doesn't exist#408kangmingtay merged 6 commits intomasterfrom
kangmingtay merged 6 commits intomasterfrom
Conversation
kangmingtay
changed the title
Contributor
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…st (supabase#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…st (supabase#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…st (supabase#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
…st (#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
xeladotbe
pushed a commit
to xeladotbe/supabase-auth
that referenced
this pull request
Sep 27, 2025
…st (supabase#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
fadymak
pushed a commit
that referenced
this pull request
Sep 30, 2025
…st (#408) * fix: check if current email exists before sending * refactor: create MailClient interface to mock mail method * refactor: merge sendEmailChange & sendSecureEmailChange methods * fix: allow single confirmation if current email doesn't exist * test: add update user email tests * add test for UserGet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
SECURE_EMAIL_CHANGE_ENABLED=true)SECURE_EMAIL_CHANGE_ENABLEDattempts to send an email confirmation link to both the current and new email, since the current email doesn't exist, the mail client fails to send the link.TemplateMailerto use an interface for theMailer. This makes mocking themailme.Mailer.Mailmethod easier rather than just mocking theEmailChangeMailmethod.