Skip to content

fix(functions): create new reader for retrying deploy - #2840

Merged
sweatybridge merged 1 commit into
developfrom
fix-retry
Nov 6, 2024
Merged

fix(functions): create new reader for retrying deploy#2840
sweatybridge merged 1 commit into
developfrom
fix-retry

Conversation

@sweatybridge

@sweatybridge sweatybridge commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix #2837

What is the new behavior?

When initiating a retry, reusing the buffer reader results in 0 length body. Instantiate a new reader instead.

Additional context

Add any other context or screenshots.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11700207355

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.803%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11700146494: -0.03%
Covered Lines: 6375
Relevant Lines: 10660

💛 - Coveralls

@sweatybridge
sweatybridge merged commit 5bd2b61 into develop Nov 6, 2024
@sweatybridge
sweatybridge deleted the fix-retry branch November 6, 2024 08:58
@github-actions github-actions Bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI doesn't show an error when Edge Functions bundle size is above the limit

2 participants