fix: throw error when static_files are used with --use-docker but Docker isn't running#4555
Open
7ttp wants to merge 2 commits into
Open
fix: throw error when static_files are used with --use-docker but Docker isn't running#45557ttp wants to merge 2 commits into
7ttp wants to merge 2 commits into
Conversation
Contributor
Author
|
@sweatybridge Please review, when available! |
Contributor
|
Deploying static files in non-docker mode is supported. Can you reproduce the issue and verify? |
Contributor
This code path falls back to deploy using API, which is the same as running If static files don't work with |
sweatybridge
requested changes
Dec 1, 2025
Contributor
sweatybridge
left a comment
There was a problem hiding this comment.
blocking until further investigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prob:
when deploying edge functions with static_files configured and --use-docker is specified while docker is not running, the cli silently falls back to the native bundler. this causes static files to be ignored, since the native bundler requires the edge runtime to be installed locally for static file bundling.
without --use-docker:static files are bundled correctly. with --use-docker and docker stopped, the deploy still succeeds but the static files are missing. so the issue only appears when a user explicitly requests docker bundling but docker isn’t availablesol:
this change adds a check that returns an explicit error when static_files is configured, --use-docker is used, and docker is unavailable, instead of silently producing an incomplete deploy.
ref