test(cli): resolve e2e images via the production resolver - #6049
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Coly010
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Follow-up to the design note on #6030:
tests/helpers/docker-image.tshand-rolled ~130 lines of the candidate/cache-check/retry algorithm that already exists aslegacyMakeDockerImageResolver, so the two could silently drift. The helper nowdrives the production resolver through a real
ChildProcessSpawner, and the onepiece that couldn't move, #6030's per-candidate budget split, which stops a stalled registry starving
the ECR → GHCR → Docker Hub fallbacks, is ported into
the resolver as an opt-in
deadline. One implementation of everything; nothing left to drift....The deadline is inert in production: both callers pass one argument, every new path is gated on it, and the pre-existing resolver tests pass untouched — the only other production edit reverts #6030's export-widening of the retry
constant. The helper keeps only test policy (memoization, serialized resolves, a docker-CLI probe, a wedged-daemon backstop), with unit coverage it never had...
Refs
basically fixes: (ss)