fix(cli): deprecate db diff --use-pg-schema (CLI-1960) - #6060
Merged
Coly010 merged 4 commits intoAug 5, 2026
Merged
Conversation
…on (CLI-1960) --use-pg-schema wraps the in-process Go library stripe/pg-schema-diff (apps/cli-go/internal/db/diff/pgschema.go) with no TS/container equivalent, so it is the M9 milestone's own sanctioned keep-in-Go exception rather than a port candidate. Deprecate the flag instead: print a TS-only stderr warning before delegating (additive to Go's own unchanged "experimental" warning), mark it deprecated in --help, and record the boundary/migration path (--use-pg-delta or the default migra engine) in SIDE_EFFECTS.md and go-cli-porting-status.md.
…ion (CLI-1960) Fix three review-flagged doc problems from the --use-pg-schema deprecation notice: replace the unresolvable ~/.claude/skills reference in SIDE_EFFECTS.md with inline keep-in-Go criteria and a CLI-1960 decision-record citation, drop the meta-commentary about PR review process, and rephrase the "sole remaining Go delegation" claim as conditional (--use-pgadmin, the db __shadow/ __db-bootstrap seams, and other in-flight M9 issues still delegate today) in both SIDE_EFFECTS.md and docs/go-cli-porting-status.md. Also drop the unowned removal-timeline promise from the deprecation warning and --help text, pointing at "the pg-delta engine" instead of the bare --use-pg-delta flag name (ambiguous with db pull's own deprecated flag), and update the integration test assertions to check a stable substring instead of the full sentence.
Contributor
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Coly010
changed the title
…0-deprecate-db-diff-use-pg-schema-keep-it-as-the-sole # Conflicts: # apps/cli/docs/go-cli-porting-status.md
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@7f747efb77870e9e6d2f864fa9b876d3ff68b280Preview package for commit |
jgoux
approved these changes
Aug 5, 2026
Coly010
deleted the
columferry/cli-1960-deprecate-db-diff-use-pg-schema-keep-it-as-the-sole
branch
August 5, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
db diff --use-pg-schemawraps the in-process Go librarygithub.com/stripe/pg-schema-diff(apps/cli-go/internal/db/diff/pgschema.go) — a direct in-process call (sql.Open+pgschema.Generate), no container image, no shell-out. There is no TS/WASM binding for this library. Per the M9 "Go removal" milestone's own pre-named decision, this is the sanctioned keep-in-Go exception — it is not being ported.This PR:
cmd/db.go:121). Fires only when--use-pg-schemais actually honored (mirrors Go's own warning gate — no notice on the explicit--from/--topath or when the flag has no effect).--helptext for the flag to note the deprecation.SIDE_EFFECTS.mdanddocs/go-cli-porting-status.mdto record the deprecation and the keep-in-Go rationale.Why (keep-in-Go rationale)
Per
github.com/stripe/pg-schema-diffbeing an in-process library with no container/binary boundary and no TS/WASM equivalent, porting isn't feasible within this milestone. Contrast with--use-pgadmin, which IS a plain container invocation and is tracked separately as a real port candidate (CLI-1968) — that one is NOT a keep-in-Go case. Full rationale recorded on the Linear issue and inSIDE_EFFECTS.md.Docs are phrased conditionally ("will be the sole remaining Go delegation once
--use-pgadmin, thedb __shadow/db __db-bootstrapseams, and other in-flight M9 issues are done") rather than claiming present-tense exclusivity, since several other delegations are still live elsewhere in the milestone.Fixes CLI-1960
Review notes
Reviewed independently by go-parity-auditor, engineer-reviewer, and architect-reviewer. All three converged on two doc issues (an unresolvable tooling-path reference, and the present-tense "sole remaining Go delegation" overclaim), plus an unowned removal-timeline promise in the warning text — all fixed in the second commit. Behavioral change confirmed additive/stderr-only with the underlying Go delegation untouched.