refactor(process-compose): isolate supervisor policies - #6084
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 442698f79a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-model # Conflicts: # packages/stack/README.md # packages/stack/docs/architecture.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a59663669e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-model # Conflicts: # packages/stack/src/versions.ts
…/process-compose-supervisor-cleanup
…/process-compose-supervisor-cleanup # Conflicts: # packages/process-compose/src/ServiceTransition.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6017cc321d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…/process-compose-supervisor-cleanup
…com:supabase/cli into agent/process-compose-supervisor-cleanup
…com:supabase/cli into agent/process-compose-supervisor-cleanup
…com:supabase/cli into agent/process-compose-supervisor-cleanup
# Conflicts: # packages/process-compose/src/Orchestrator.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c825a0eaf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…correctness' into agent/process-compose-supervisor-cleanup
…correctness' into agent/process-compose-supervisor-cleanup
…/process-compose-supervisor-cleanup
…/process-compose-supervisor-cleanup
…-model # Conflicts: # packages/stack/src/ServiceActivation.ts # packages/stack/src/StackBuilder.ts # packages/stack/src/StackLifecycleCoordinator.ts
…gent/process-compose-supervisor-cleanup # Conflicts: # packages/process-compose/docs/architecture.md # packages/process-compose/src/Orchestrator.ts # packages/process-compose/src/ServiceTransition.ts # packages/stack/src/ServiceActivation.ts # packages/stack/src/StackBuilder.ts # packages/stack/src/StackLifecycleCoordinator.ts
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@4358f44733aa9c11e97db9129243da60f5c9d355Preview package for commit |
## What changed - makes StackBuilder the sole owner of dependency topology and passes explicit dependencies into every service factory, including the native-initialization versus Docker-readiness choice for PostgREST - moves Docker network and port argument construction into service factories and migrates PostgreSQL, Auth, and PostgREST onto the common Docker definition helper - centralizes container identity so launch, exact cleanup, orphan cleanup, and catalog-derived candidate cleanup use the same naming source - captures exact build-produced cleanup targets before persistence and orchestrator setup, and disposes already-started resources after any partial startup failure - expands semantic service-definition coverage and documents the exact-versus-candidate cleanup model ## Why Service construction and resource identity were split across the builder, individual factories, and fallback cleanup code. Keeping topology in the builder while concentrating executable details and Docker identity in factories makes service definitions easier to change safely, prevents launch and cleanup names from drifting, and ensures failed startup cannot leave an earlier service running. Depends on supabase#6085 and supabase#6084 (and transitively supabase#6081, supabase#6080, and supabase#6078).
2 participants
Summary
Why
The process supervisor should remain domain-neutral and keep policy decisions independently testable without changing the lifecycle semantics established by the preceding work.
Depends on #6080 and transitively on #6078.